Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(legend): Simplify the code and tweak performance #2663

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

jolevesq
Copy link
Member

@jolevesq jolevesq commented Dec 13, 2024

Closes #2660

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

  • Fix missing icon for WMS
  • Fix wrong order on load for legend tab
  • Simplification for component
  • Memo to reduce renderer

TODO in anther PR

  • Throttle the store to minimize re render
  • Refactor the tab footer to remove render when tab is not selected.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Hosted Dec 19th 4pm:
https://jolevesq.github.io/geoview/demos-navigator.html?config=./configs/navigator/19-geojson.json
https://jolevesq.github.io/geoview/demos-navigator.html?config=./configs/navigator/28-geocore.json

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@jolevesq jolevesq requested review from DamonU2 and PVautour December 19, 2024 21:21
@jolevesq jolevesq marked this pull request as ready for review December 19, 2024 21:21
Copy link
Member

@DamonU2 DamonU2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PVautour)

Copy link
Member Author

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 9 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PVautour)

@jolevesq jolevesq merged commit 7c8c489 into Canadian-Geospatial-Platform:develop Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance for Legend
2 participants